Upstream information
Description
In the Linux kernel, the following vulnerability has been resolved:mm: gup: stop abusing try_grab_folio
A kernel warning was reported when pinning folio in CMA memory when
launching SEV virtual machine. The splat looks like:
[ 464.325306] WARNING: CPU: 13 PID: 6734 at mm/gup.c:1313 __get_user_pages+0x423/0x520
[ 464.325464] CPU: 13 PID: 6734 Comm: qemu-kvm Kdump: loaded Not tainted 6.6.33+ #6
[ 464.325477] RIP: 0010:__get_user_pages+0x423/0x520
[ 464.325515] Call Trace:
[ 464.325520] <TASK>
[ 464.325523] ? __get_user_pages+0x423/0x520
[ 464.325528] ? __warn+0x81/0x130
[ 464.325536] ? __get_user_pages+0x423/0x520
[ 464.325541] ? report_bug+0x171/0x1a0
[ 464.325549] ? handle_bug+0x3c/0x70
[ 464.325554] ? exc_invalid_op+0x17/0x70
[ 464.325558] ? asm_exc_invalid_op+0x1a/0x20
[ 464.325567] ? __get_user_pages+0x423/0x520
[ 464.325575] __gup_longterm_locked+0x212/0x7a0
[ 464.325583] internal_get_user_pages_fast+0xfb/0x190
[ 464.325590] pin_user_pages_fast+0x47/0x60
[ 464.325598] sev_pin_memory+0xca/0x170 [kvm_amd]
[ 464.325616] sev_mem_enc_register_region+0x81/0x130 [kvm_amd]
Per the analysis done by yangge, when starting the SEV virtual machine, it
will call pin_user_pages_fast(..., FOLL_LONGTERM, ...) to pin the memory.
But the page is in CMA area, so fast GUP will fail then fallback to the
slow path due to the longterm pinnalbe check in try_grab_folio().
The slow path will try to pin the pages then migrate them out of CMA area.
But the slow path also uses try_grab_folio() to pin the page, it will
also fail due to the same check then the above warning is triggered.
In addition, the try_grab_folio() is supposed to be used in fast path and
it elevates folio refcount by using add ref unless zero. We are guaranteed
to have at least one stable reference in slow path, so the simple atomic add
could be used. The performance difference should be trivial, but the
misuse may be confusing and misleading.
Redefined try_grab_folio() to try_grab_folio_fast(), and try_grab_page()
to try_grab_folio(), and use them in the proper paths. This solves both
the abuse and the kernel warning.
The proper naming makes their usecase more clear and should prevent from
abusing in the future.
peterx said:
: The user will see the pin fails, for gpu-slow it further triggers the WARN
: right below that failure (as in the original report):
:
: folio = try_grab_folio(page, page_increm - 1,
: foll_flags);
: if (WARN_ON_ONCE(!folio)) { <------------------------ here
: /*
: * Release the 1st page ref if the
: * folio is problematic, fail hard.
: */
: gup_put_folio(page_folio(page), 1,
: foll_flags);
: ret = -EFAULT;
: goto out;
: }
[1] https://lore.kernel.org/linux-mm/1719478388-31917-1-git-send-email-yangge1116@126.com/
[shy828301@gmail.com: fix implicit declaration of function try_grab_folio_fast]
Link: https://lkml.kernel.org/r/CAHbLzkowMSso-4Nufc9hcMehQsK9PNz3OSu-+eniU-2Mm-xjhA@mail.gmail.com
SUSE information
Overall state of this security issue: Resolved
This issue is currently rated as having moderate severity.
| National Vulnerability Database | SUSE | |
|---|---|---|
| Base Score | 5.5 | 5.5 |
| Vector | CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H | CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H |
| Attack Vector | Local | Local |
| Attack Complexity | Low | Low |
| Privileges Required | Low | Low |
| User Interaction | None | None |
| Scope | Unchanged | Unchanged |
| Confidentiality Impact | None | None |
| Integrity Impact | None | None |
| Availability Impact | High | High |
| CVSSv3 Version | 3.1 | 3.1 |
| SUSE | |
|---|---|
| Base Score | 6.8 |
| Vector | CVSS:4.0/AV:L/AC:L/AT:N/PR:L/UI:N/VC:N/VI:N/VA:H/SC:N/SI:N/SA:N |
| Attack Vector | Local |
| Attack Complexity | Low |
| Attack Requirements | None |
| Privileges Required | Low |
| User Interaction | None |
| Vulnerable System Confidentiality Impact | None |
| Vulnerable System Integrity Impact | None |
| Vulnerable System Availability Impact | High |
| Subsequent System Confidentiality Impact | None |
| Subsequent System Integrity Impact | None |
| Subsequent System Availability Impact | None |
| CVSSv4 Version | 4.0 |
Status of this issue by product and package
Please note that this evaluation state might be work in progress, incomplete or outdated. Also information for service packs in the LTSS phase is only included for issues meeting the LTSS criteria. If in doubt, feel free to contact us for clarification. The updates are grouped by state of their lifecycle. SUSE product lifecycles are documented on the lifecycle page.
| Product(s) | Source package | State |
|---|---|---|
| Products under general support and receiving all security fixes. | ||
| SUSE Linux Enterprise Desktop 15 SP5 | kernel-default | Not affected |
| SUSE Linux Enterprise Desktop 15 SP5 | kernel-source | Not affected |
| SUSE Linux Enterprise Desktop 15 SP6 | kernel-default | Not affected |
| SUSE Linux Enterprise Desktop 15 SP6 | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 12 SP5 | kernel-default | Not affected |
| SUSE Linux Enterprise High Performance Computing 12 SP5 | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 12 SP5 | kernel-source-azure | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP5 | kernel-default | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP5 | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP5 | kernel-source-azure | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP6 | kernel-default | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP6 | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP6 | kernel-source-azure | Not affected |
| SUSE Linux Enterprise Micro 5.1 | kernel-default | Not affected |
| SUSE Linux Enterprise Micro 5.1 | kernel-rt | Not affected |
| SUSE Linux Enterprise Micro 5.1 | kernel-source-rt | Not affected |
| SUSE Linux Enterprise Micro 5.2 | kernel-default | Not affected |
| SUSE Linux Enterprise Micro 5.2 | kernel-rt | Not affected |
| SUSE Linux Enterprise Micro 5.2 | kernel-source-rt | Not affected |
| SUSE Linux Enterprise Micro 5.3 | kernel-default | Not affected |
| SUSE Linux Enterprise Micro 5.3 | kernel-rt | Not affected |
| SUSE Linux Enterprise Micro 5.3 | kernel-source-rt | Not affected |
| SUSE Linux Enterprise Micro 5.4 | kernel-default | Not affected |
| SUSE Linux Enterprise Micro 5.4 | kernel-rt | Not affected |
| SUSE Linux Enterprise Micro 5.4 | kernel-source-rt | Not affected |
| SUSE Linux Enterprise Micro 5.5 | kernel-source-rt | Not affected |
| SUSE Linux Enterprise Micro 6.0 | kernel-default | Not affected |
| SUSE Linux Enterprise Micro 6.0 | kernel-source | Not affected |
| SUSE Linux Enterprise Micro 6.0 | kernel-source-rt | Not affected |
| SUSE Linux Enterprise Module for Basesystem 15 SP5 | kernel-default | Not affected |
| SUSE Linux Enterprise Module for Basesystem 15 SP5 | kernel-source | Not affected |
| SUSE Linux Enterprise Module for Basesystem 15 SP6 | kernel-default | Not affected |
| SUSE Linux Enterprise Module for Basesystem 15 SP6 | kernel-source | Not affected |
| SUSE Linux Enterprise Module for Development Tools 15 SP5 | kernel-default | Not affected |
| SUSE Linux Enterprise Module for Development Tools 15 SP5 | kernel-source | Not affected |
| SUSE Linux Enterprise Module for Development Tools 15 SP6 | kernel-default | Not affected |
| SUSE Linux Enterprise Module for Development Tools 15 SP6 | kernel-source | Not affected |
| SUSE Linux Enterprise Module for Public Cloud 15 SP5 | kernel-source-azure | Not affected |
| SUSE Linux Enterprise Module for Public Cloud 15 SP6 | kernel-source-azure | Not affected |
| SUSE Linux Enterprise Real Time 12 SP5 | kernel-source-rt | Not affected |
| SUSE Linux Enterprise Real Time 15 SP5 | kernel-source-rt | Not affected |
| SUSE Linux Enterprise Real Time 15 SP6 | kernel-source-rt | Not affected |
| SUSE Linux Enterprise Server 12 SP5 | kernel-default | Not affected |
| SUSE Linux Enterprise Server 12 SP5 | kernel-source | Not affected |
| SUSE Linux Enterprise Server 12 SP5 | kernel-source-azure | Not affected |
| SUSE Linux Enterprise Server 12 SP5-LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise Server 12 SP5-LTSS | kernel-source-azure | Not affected |
| SUSE Linux Enterprise Server 15 SP5 | kernel-default | Not affected |
| SUSE Linux Enterprise Server 15 SP5 | kernel-source | Not affected |
| SUSE Linux Enterprise Server 15 SP5 | kernel-source-azure | Not affected |
| SUSE Linux Enterprise Server 15 SP6 | kernel-default | Not affected |
| SUSE Linux Enterprise Server 15 SP6 | kernel-source | Not affected |
| SUSE Linux Enterprise Server 15 SP6 | kernel-source-azure | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 12 SP5 | kernel-default | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 12 SP5 | kernel-source | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 12 SP5 | kernel-source-azure | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 15 SP5 | kernel-default | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 15 SP5 | kernel-source | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 15 SP5 | kernel-source-azure | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 15 SP6 | kernel-default | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 15 SP6 | kernel-source | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 15 SP6 | kernel-source-azure | Not affected |
| SUSE Manager Proxy 4.3 | kernel-default | Not affected |
| SUSE Manager Proxy 4.3 | kernel-source | Not affected |
| SUSE Manager Retail Branch Server 4.3 | kernel-default | Not affected |
| SUSE Manager Retail Branch Server 4.3 | kernel-source | Not affected |
| SUSE Manager Server 4.3 | kernel-default | Not affected |
| SUSE Manager Server 4.3 | kernel-source | Not affected |
| SUSE Real Time Module 15 SP5 | kernel-source-rt | Not affected |
| SUSE Real Time Module 15 SP6 | kernel-source-rt | Not affected |
| openSUSE Leap 15.5 | kernel-default | Not affected |
| openSUSE Leap 15.5 | kernel-source | Not affected |
| openSUSE Leap 15.5 | kernel-source-azure | Not affected |
| openSUSE Leap 15.5 | kernel-source-rt | Not affected |
| openSUSE Leap 15.6 | kernel-default | Not affected |
| openSUSE Leap 15.6 | kernel-source | Not affected |
| openSUSE Leap 15.6 | kernel-source-azure | Not affected |
| openSUSE Leap 15.6 | kernel-source-rt | Not affected |
| Products under Long Term Service Pack support and receiving important and critical security fixes. | ||
| SUSE Linux Enterprise Desktop 15 SP4 | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP2 | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP2-ESPOS | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP2-LTSS | kernel-default | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP2-LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP3 | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP3-ESPOS | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP3-LTSS | kernel-default | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP3-LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP4 | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP4-ESPOS | kernel-default | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP4-ESPOS | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP4-LTSS | kernel-default | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP4-LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise Module for Basesystem 15 SP2 | kernel-source | Not affected |
| SUSE Linux Enterprise Module for Basesystem 15 SP3 | kernel-source | Not affected |
| SUSE Linux Enterprise Module for Basesystem 15 SP4 | kernel-source | Not affected |
| SUSE Linux Enterprise Module for Development Tools 15 SP2 | kernel-source | Not affected |
| SUSE Linux Enterprise Module for Development Tools 15 SP3 | kernel-source | Not affected |
| SUSE Linux Enterprise Module for Development Tools 15 SP4 | kernel-source | Not affected |
| SUSE Linux Enterprise Server 11 SP4 LTSS EXTREME CORE | kernel-default | Not affected |
| SUSE Linux Enterprise Server 11 SP4 LTSS EXTREME CORE | kernel-source | Not affected |
| SUSE Linux Enterprise Server 15 SP2 | kernel-source | Not affected |
| SUSE Linux Enterprise Server 15 SP2-LTSS | kernel-default | Not affected |
| SUSE Linux Enterprise Server 15 SP2-LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise Server 15 SP3 | kernel-source | Not affected |
| SUSE Linux Enterprise Server 15 SP3-LTSS | kernel-default | Not affected |
| SUSE Linux Enterprise Server 15 SP3-LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise Server 15 SP4 | kernel-source | Not affected |
| SUSE Linux Enterprise Server 15 SP4-LTSS | kernel-default | Not affected |
| SUSE Linux Enterprise Server 15 SP4-LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 15 SP2 | kernel-default | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 15 SP2 | kernel-source | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 15 SP3 | kernel-default | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 15 SP3 | kernel-source | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 15 SP4 | kernel-default | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 15 SP4 | kernel-source | Not affected |
| Products past their end of life and not receiving proactive updates anymore. | ||
| HPE Helion OpenStack 8 | kernel-source | Not affected |
| SUSE CaaS Platform 4.0 | kernel-source | Not affected |
| SUSE CaaS Platform Toolchain 3 | kernel-source | Not affected |
| SUSE Enterprise Storage 6 | kernel-source | Not affected |
| SUSE Enterprise Storage 7 | kernel-source | Not affected |
| SUSE Enterprise Storage 7.1 | kernel-source | Not affected |
| SUSE Linux Enterprise Desktop 11 SP4 | kernel-source | Not affected |
| SUSE Linux Enterprise Desktop 12 SP2 | kernel-source | Not affected |
| SUSE Linux Enterprise Desktop 12 SP3 | kernel-source | Not affected |
| SUSE Linux Enterprise Desktop 12 SP4 | kernel-source | Not affected |
| SUSE Linux Enterprise Desktop 15 | kernel-source | Not affected |
| SUSE Linux Enterprise Desktop 15 SP1 | kernel-source | Not affected |
| SUSE Linux Enterprise Desktop 15 SP2 | kernel-source | Not affected |
| SUSE Linux Enterprise Desktop 15 SP3 | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP1 | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP1-ESPOS | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15 SP1-LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15-ESPOS | kernel-source | Not affected |
| SUSE Linux Enterprise High Performance Computing 15-LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise Micro 5.0 | kernel-default | Not affected |
| SUSE Linux Enterprise Module for Basesystem 15 | kernel-source | Not affected |
| SUSE Linux Enterprise Module for Basesystem 15 SP1 | kernel-source | Not affected |
| SUSE Linux Enterprise Module for Development Tools 15 | kernel-source | Not affected |
| SUSE Linux Enterprise Module for Development Tools 15 SP1 | kernel-source | Not affected |
| SUSE Linux Enterprise Point of Sale 12 SP2-CLIENT | kernel-source | Not affected |
| SUSE Linux Enterprise Real Time 15 SP2 | kernel-source | Not affected |
| SUSE Linux Enterprise Real Time 15 SP3 | kernel-source | Not affected |
| SUSE Linux Enterprise Real Time 15 SP3 | kernel-source-rt | Not affected |
| SUSE Linux Enterprise Real Time 15 SP4 | kernel-source | Not affected |
| SUSE Linux Enterprise Real Time 15 SP4 | kernel-source-rt | Not affected |
| SUSE Linux Enterprise Server 11 SP4 | kernel-source | Not affected |
| SUSE Linux Enterprise Server 11 SP4 LTSS | kernel-default | Not affected |
| SUSE Linux Enterprise Server 11 SP4 LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise Server 11 SP4-LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise Server 12 SP2 | kernel-source | Not affected |
| SUSE Linux Enterprise Server 12 SP2-BCL | kernel-source | Not affected |
| SUSE Linux Enterprise Server 12 SP2-ESPOS | kernel-source | Not affected |
| SUSE Linux Enterprise Server 12 SP2-LTSS | kernel-default | Not affected |
| SUSE Linux Enterprise Server 12 SP2-LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise Server 12 SP3 | kernel-source | Not affected |
| SUSE Linux Enterprise Server 12 SP3-BCL | kernel-source | Not affected |
| SUSE Linux Enterprise Server 12 SP3-ESPOS | kernel-source | Not affected |
| SUSE Linux Enterprise Server 12 SP3-LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise Server 12 SP4 | kernel-source | Not affected |
| SUSE Linux Enterprise Server 12 SP4-ESPOS | kernel-source | Not affected |
| SUSE Linux Enterprise Server 12 SP4-LTSS | kernel-default | Not affected |
| SUSE Linux Enterprise Server 12 SP4-LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise Server 15 | kernel-source | Not affected |
| SUSE Linux Enterprise Server 15 SP1 | kernel-source | Not affected |
| SUSE Linux Enterprise Server 15 SP1-BCL | kernel-source | Not affected |
| SUSE Linux Enterprise Server 15 SP1-LTSS | kernel-default | Not affected |
| SUSE Linux Enterprise Server 15 SP1-LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise Server 15 SP2-BCL | kernel-source | Not affected |
| SUSE Linux Enterprise Server 15 SP3-BCL | kernel-source | Not affected |
| SUSE Linux Enterprise Server 15-LTSS | kernel-default | Not affected |
| SUSE Linux Enterprise Server 15-LTSS | kernel-source | Not affected |
| SUSE Linux Enterprise Server for Raspberry Pi 12 SP2 | kernel-source | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 12 SP2 | kernel-source | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 12 SP3 | kernel-source | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 12 SP4 | kernel-source | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 15 | kernel-source | Not affected |
| SUSE Linux Enterprise Server for SAP Applications 15 SP1 | kernel-source | Not affected |
| SUSE Manager Proxy 4.0 | kernel-source | Not affected |
| SUSE Manager Proxy 4.1 | kernel-source | Not affected |
| SUSE Manager Proxy 4.2 | kernel-source | Not affected |
| SUSE Manager Retail Branch Server 4.0 | kernel-source | Not affected |
| SUSE Manager Retail Branch Server 4.1 | kernel-source | Not affected |
| SUSE Manager Retail Branch Server 4.2 | kernel-source | Not affected |
| SUSE Manager Server 4.0 | kernel-source | Not affected |
| SUSE Manager Server 4.1 | kernel-source | Not affected |
| SUSE Manager Server 4.2 | kernel-source | Not affected |
| SUSE OpenStack Cloud 7 | kernel-source | Not affected |
| SUSE OpenStack Cloud 8 | kernel-source | Not affected |
| SUSE OpenStack Cloud 9 | kernel-source | Not affected |
| SUSE OpenStack Cloud Crowbar 8 | kernel-source | Not affected |
| SUSE OpenStack Cloud Crowbar 9 | kernel-source | Not affected |
| SUSE Real Time Module 15 SP3 | kernel-source-rt | Not affected |
| SUSE Real Time Module 15 SP4 | kernel-source-rt | Not affected |
| openSUSE Leap 15.3 | kernel-source | Not affected |
| openSUSE Leap 15.3 | kernel-source-rt | Not affected |
| openSUSE Leap 15.4 | kernel-source | Not affected |
| openSUSE Leap 15.4 | kernel-source-azure | Not affected |
| openSUSE Leap 15.4 | kernel-source-rt | Not affected |
| Products at an unknown state of their lifecycle. | ||
| SUSE Linux Enterprise Server 12 SP5-LTSS-EXTENDED-SECURITY | kernel-source | Not affected |
| SUSE Linux Enterprise Server 12 SP5-LTSS-EXTENDED-SECURITY | kernel-source-azure | Not affected |
SUSE Timeline for this CVE
CVE page created: Wed Aug 28 12:00:07 2024CVE page last modified: Sat Oct 5 00:24:07 2024